Skip to content

Make PageUp/PageDown and CtrlPageUp/CtrlPageDown windows only #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 11, 2019
Merged

Make PageUp/PageDown and CtrlPageUp/CtrlPageDown windows only #1032

merged 5 commits into from
Sep 11, 2019

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Sep 11, 2019 •
edited
Loading

Make PageUp/PageDown and CtrlPageUp/CtrlPageDown windows only because

  1. On Linux and macOS, Console.SetWindowPosition throw PlatformNotSupportedException.
  2. On macOS, PageUp and PageDown get intercepted by the terminal and perform the same behavior as moving one page up or down.
    Ctrl+PageUp and Ctrl+PageDown are also intercepted by the terminal and do the same as PageUp and PageDown

Fix #1016

@daxian-dbw daxian-dbw requested a review from lzybkr September 11, 2019 00:28
@daxian-dbw
Copy link
Member Author

@msftrncs can you please review? Thanks!

rjmholt
rjmholt approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on your description of the initial problem. Left a comment about comments

@daxian-dbw
Copy link
Member Author

Thanks for the review @rjmholt!

@daxian-dbw daxian-dbw merged commit d6b120a into PowerShell:master Sep 11, 2019
@daxian-dbw daxian-dbw deleted the pageupdown branch September 11, 2019 21:36
This was referenced Sep 11, 2019
Closed
Closed
Closed
@daxian-dbw daxian-dbw added this to the 2.0.0-beta5 milestone Sep 13, 2019
@daxian-dbw daxian-dbw mentioned this pull request Sep 26, 2019
Closed
@daxian-dbw daxian-dbw mentioned this pull request Dec 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzybkr lzybkr Awaiting requested review from lzybkr

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-beta5
Development

Successfully merging this pull request may close these issues.

PageDown while pwsh is processing command => System.PlatformNotSupportedException
2 participants
@daxian-dbw @rjmholt