-
Notifications
You must be signed in to change notification settings - Fork 1
Address license handling #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
877e21c
to
be2320e
Compare
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
5a7859e
to
1c09798
Compare
@TonyXiang8787 @mgovers Can you take a look at this. Some remarks below: Currently, I am only doing this for In addition, I am testing here for now since I don't have permissions to create a new repo and I can test with what is currently set up in here. But the clean repo can be created as a follow up. Proof current works: https://github.com/PowerGridModel/pgm-build-dependencies/actions/runs/18343412484/job/52244043851. Furthermore, please take a look at the One final question: Should we test we the newly built wheel against current pgm? Or the fact that we were able to build afterwards is enough proof that it works? If we want additional testing, do we manually check or do we set some test workflow to be checked before publishing is enabled? |
.github/workflows/sync-headers.yml
Outdated
echo "Please check the license scan results manually." | ||
else | ||
echo "License cleanup completed successfully" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"check manually" implies that it should not upload. please make sure that that is indeed correctly handled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant it as something went wrong, we still upload whatever is in the scan result, take a look. Should I phrase differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should upload the scan result but not do the actual committing of the files if something went wrong. we may accidentally commit something we should not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make sure then that the committing is only done if scanning was successful.
Up until this point, I have tested making a new release in a fork, and I will now extend this workflow to the whole repo (not only the |
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
22761a3 was tested in figueroa1395#2 and https://github.com/figueroa1395/pgm-build-dependencies/actions/runs/18586672383/job/52992052911. The correct building was tested in https://github.com/figueroa1395/power-grid-model/actions/runs/18587252789 (please focus on the building only as that fork fails because it has no releases. Everything works as expected. In any case, manual run of this action is in https://github.com/PowerGridModel/pgm-build-dependencies/actions/runs/18587523173 Note: The CI in the PR doesn't tell anything, check the running action cited last above. |
In this PR I try to remove the files that aren't compliant with PGM's license from the dependencies, and then to proceed with the building of such dependencies.
The workflow is as follows: Use
fossology-action
(which usesfossology
engine under the hood - same tooling used by LF), store the licensing results in ajson
file, parse that file usingjq
to find the files with undesirable license, remove those files, build.