Skip to content

Conversation

danmarsden
Copy link
Contributor

This is a rebased version of #298 on top of the MOODLE_400_STABLE branch - which I'm guessing is the main branch to use for PR's? - I've taken on board the comments from @mchurchward on the original #298 and updated the user id field lang string as well "id" - to "User Id" because it's not clear if that id is the course id/userid or activity id either. Note this does make a change to the csv header as well, but I think it makes sense.

let me know if you want any other changes, or if it needs to be a PR against a different branch!

thanks!

@danmarsden danmarsden force-pushed the fix298 branch 2 times, most recently from c066827 to 50aff3c Compare December 19, 2022 23:10
Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks. If this is desired pre-Moodle 4, let me know and I will backport it.

@mchurchward mchurchward merged commit 566a116 into PoetOS:MOODLE_400_STABLE Dec 20, 2022
@danmarsden
Copy link
Contributor Author

Thanks Mike! - we don't need it on our end pre 4.0, but nice to have it in the 4.0 and higher release :-)

@dumontj01
Copy link

Hello,
I'm writing to you because I think the merge didn't work. I can't find commit 566a116 in the history of the MOODLE_400_STABLE branch, nor in any of the following branches. It looks as if the merge was performed in head detached mode, because when you go to this commit, the following message is displayed: “This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.” As a result, I can't find the expected changes in the code.
The absence of this feature was pointed out before me by another person in the moodle forum: https://moodle.org/mod/forum/discuss.php?d=462356
Sincerely

dumontj01 pushed a commit to dumontj01/moodle-mod_questionnaire that referenced this pull request Jun 8, 2025
* add idnumber export option

* Fix up lang strings for export fields.

Co-authored-by: root <[email protected]>

cherry-pick form commit 566a116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants