Skip to content

Reconnect when read fails due to broken pipe. #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reconnect when read fails due to broken pipe. #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.pod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,6 +1619,10 @@ Ivan Kruglov

Steffen Mueller <[email protected]>

=item *

David Millar <[email protected]>

=back

=head1 AUTHORS
Expand Down
4 changes: 4 additions & 0 deletions lib/Redis.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ use constant EWOULDBLOCK => eval {Errno::EWOULDBLOCK} || -1E9;
use constant EAGAIN => eval {Errno::EAGAIN} || -1E9;
use constant EINTR => eval {Errno::EINTR} || -1E9;
use constant ECONNRESET => eval {Errno::ECONNRESET} || -1E9;
use constant EPIPE => eval {Errno::EPIPE} || -1E9;

# According to IO::Socket::SSL documentation, 16k is the maximum
# size of an SSL frame and because sysread returns data from only
Expand Down Expand Up @@ -1038,6 +1039,9 @@ sub __try_read_sock {
## or because an intermediate proxy shut down our connection using its internal timeout counter
return 0 if ($err && $err == ECONNRESET);

## Broken pipe, we will need to reconnect
$self->__throw_reconnect('Broken pipe') if $err == EPIPE;

## result is undef but err is 0? should never happen
return if $err == 0;

Expand Down