class.c: Correct allocation of OP_ARGCHECK aux structure #21957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
reviewed
Feb 8, 2024
class.c
Outdated
| UNOP_AUX_item *aux; | ||
| Newx(aux, 3, UNOP_AUX_item); | ||
| struct op_argcheck_aux *aux = (struct op_argcheck_aux *) | ||
| PerlMemShared_malloc(sizeof(struct op_argcheck_aux)); |
There was a problem hiding this comment.
Good call. Force-pushed.
leonerd
force-pushed
the
bugfix-class_c-alloc-argcheck-aux
branch
from
738fb39 to
4da33e4
Compare
The original code was wrong on two counts: * Using Newx() instead of PerlMemShared_malloc() * Creating a generic UNOP_AUX_item array instead of the special struct type
leonerd
force-pushed
the
bugfix-class_c-alloc-argcheck-aux
branch
from
4da33e4 to
02eab5f
Compare
|
The first smokes are showing this fixes it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was wrong on two counts: