(perl #17844) don't update SvCUR until after we've done moving #17845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvCUR() before the SvGROW() calls could result in reading beyond the end of a buffer. It wasn't a problem in the normal case, since sv_grow() just calls realloc() which has its own notion of how big the memory block is, but if the SV is SvOOK() sv_backoff() tries to move SvCUR()+1 bytes, which might be larger than the currently allocated size of the PV.
khwilliamson
approved these changes
Jul 30, 2020
atoomic
approved these changes
Jul 30, 2020
toddr
added
Ready-to-merge
and removed
do not merge
|
Per @tonycoz this is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SvCUR()before theSvGROW()calls could result in reading beyond theend of a buffer.
It wasn't a problem in the normal case, since
sv_grow()just callsrealloc()which has its own notion of how big the memory block is, butif the SV is
SvOOK(),sv_backoff()tries to moveSvCUR()+1bytes, whichmight be larger than the currently allocated size of the PV.
Note: Tony's original patch did not apply cleanly, but the changes required to correct this were trivial. I also altered the commit message and comments to use the new issue number.