use semicolon to separate statements #17833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice catch! |
One of the statements in warnings.pm was terminated with a comma rather than a semicolon, most likely as a typo. There's no reason for it to be a comma, so change it to a semicolon for clarity and to avoid potential issues with statement reordering.
Contributor
|
@xsawyerx can you explain the Not following the work-flow here. |
Contributor
Yes, blead (what we in Perl 5 call 'master') is frozen until the pumpking issues the first development release of the next cycle. Patches and pull requests can be offered, and those with commit bits can create branches in the core repository -- but no commits to blead. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the statements in warnings.pm was terminated with a comma rather
than a semicolon, most likely as a typo. There's no reason for it to be
a comma, so change it to a semicolon for clarity and to avoid potential
issues with statement reordering.