Skip to content

Conversation

@vividsnow
Copy link
Contributor

IO::Socket docs states that passing Blocking => 0 will be set socket to non-blocking mode

IO::Socket docs states that passing Blocking => 0 will be set socket to non-blocking mode
@vividsnow vividsnow changed the title synchronize behavior with module documentation IO::Socket::UNIX: synchronize behavior with module documentation May 16, 2020
@jkeenan
Copy link
Contributor

jkeenan commented May 16, 2020

IO::Socket docs states that passing Blocking => 0 will be set socket to non-blocking mode

We have to be careful about modifying the behavior of a module which has shipped with the Perl core distribution since 1998 and upon which a tremendous amount of production code is likely to depend. We have to consider the possibility that the code is correct and that it is the documentation which is wrong.

I don't know enough about sockets to evaluate this further, so others should study this.

Thank you very much.
Jim Keenan

@Leont
Copy link
Contributor

Leont commented May 16, 2020

This looks logical to me.

@toddr toddr requested review from toddr and removed request for toddr May 17, 2020 15:27
@toddr
Copy link
Member

toddr commented May 17, 2020

t/porting/authors.t - vividsnow [email protected] not found in AUTHORS

@toddr
Copy link
Member

toddr commented May 18, 2020

2020-05-18T11:43:31.2651094Z # not ok 4 - dist/IO/lib/IO/Socket/UNIX.pm version 1.41
2020-05-18T11:43:31.2825000Z t/porting/cmp_version .......................................... FAILED at test 4

@toddr
Copy link
Member

toddr commented May 18, 2020

It looks like the only remaining change required is to bump $VERSION.

@toddr
Copy link
Member

toddr commented May 19, 2020

Thank you for this submission @vividsnow. We are currently stabilizing for Perl 5.32.0. I think our current protocol requires we hold this pull request until that is released in about a month!

@toddr toddr added this to the 5.33.1 milestone May 19, 2020
@vividsnow
Copy link
Contributor Author

ok, thank you

@xsawyerx xsawyerx added the do not merge Don't merge this PR, at least for now label Jun 20, 2020
@toddr toddr removed the do not merge Don't merge this PR, at least for now label Jul 30, 2020
@toddr toddr merged commit c643996 into Perl:blead Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants