Skip to content

Conversation

@lightsey
Copy link
Contributor

The must match substring SV returned by re_intuit_start() may be
freed after an attempt at matching the pattern.

Fixes #17734

The must match substring SV returned by re_intuit_start() may be
freed after an attempt at matching the pattern.

Fixes Perl#17734
@toddr toddr added this to the 5.33.1 milestone May 19, 2020
@atoomic atoomic requested review from atoomic and khwilliamson May 19, 2020 15:13
@atoomic
Copy link
Member

atoomic commented May 19, 2020

indeed as mentioned here the SV can be freed during execution of the regex engine
https://github.com/Perl/perl5/blob/blead/regcomp.c#L21508

I wonder if there are other locations having the same issue.

@atoomic
Copy link
Member

atoomic commented May 19, 2020

note that this is already fixed by 07b2324
we should close this case

Copy link
Member

@atoomic atoomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in a different way by 07b2324
this commit does not seem needed anymore

@atoomic atoomic closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use after free in unicode wildcard property matching

3 participants