win32.c: rework the waitpid(-1, WNOHANG) fix #17657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops! While 08e55ec made waitpid(-1, WNOHANG) not segfault, it introduced another problem: when retry == 1, MsgWaitForMultipleObjects() will sometimes be called with a very large timeout due to unsigned integer overflow. This is *exactly* the same problem that the comment above the loop warns about.
xenu
force-pushed
the
xenu/win32_msgwait_2
branch
from
aee2be8 to
ae1f5af
Compare
|
Force-pushed to re-run tests. I think they failed for unrelated reasons. |
atoomic
approved these changes
Mar 19, 2020
karenetheridge
added
backport-5.30
and removed
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops! While 08e55ec made
waitpid(-1, WNOHANG)not segfault, it introduced another problem:when
retry == 1, MsgWaitForMultipleObjects() will sometimes becalled with a very large timeout due to unsigned integer overflow.
This is exactly the same problem that the comment above the loop
warns about.