Remove obsolete FCRYPT ifdefs and associated PL_cryptseen #17624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: smoke-me/jkeenan/rleach/ghpr-17624-obsolete branch. |
atoomic
approved these changes
Mar 12, 2020
|
On Thu, Mar 12, 2020 at 07:36:38PM -0700, Nicolas R. wrote:
@tonycoz / @iabyn this looks good to me, any reason to do not merge this PR as it?
It looks good to me, but I think we should merge early in the 5.33.x
cycle.
…--
"You're so sadly neglected, and often ignored.
A poor second to Belgium, When going abroad."
-- Monty Python, "Finland"
|
tonycoz
approved these changes
Mar 18, 2020
|
@richardleach can you rebase please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #17623, this commit removes what seems to be obsolete functionality, the use of which would never have been enabled by Configure or platform-specific Makefiles.
This isn't necessarily intended for immediate merging, but it would be great if someone could push to a smoke-me branch...