PG-1963: Implement caching for HTTP requests #22
+634
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a basic cache using the dshash infrasturcture in PostgreSQL: we simply cache the HTTP results based on the Cache-Control property sent by the server. The cache itself is relatively simple, most of the impelementation is a should-be-safe C++ wrapper around dshash, and infrastructure to handle pg_try properly everywhere. No proper tests added yet, as Keycloak decided to don't allow caching for issuer and jwks requests at all, so the cache is not used in our rspec tests. We likely have to add a more complex setup there with an nginx proxy in between.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a basic cache using the dshash infrasturcture in PostgreSQL: we simply cache the HTTP results based on the Cache-Control property sent by the server.
The cache itself is relatively simple, most of the impelementation is a should-be-safe C++ wrapper around dshash, and infrastructure to handle pg_try properly everywhere.
No proper tests added yet, as Keycloak decided to don't allow caching for issuer and jwks requests at all, so the cache is not used in our rspec tests. We likely have to add a more complex setup there with an nginx proxy in between.