This repository was archived by the owner on Sep 26, 2019. It is now read-only.
Repair test-support publishing tasks #1938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Sep 13, 2019
Contributor
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
LGTM because I can't think of a better option, but it's starting to feel pretty hacky. Would it be better to just put the DSL in a src/main/java package so it can be distributed normally?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each test-support jar must be published with its own 'pom'
file, to ensure its dependencies are correctly documented.
As such, all test-support jars are now published under
tech.pegasys.pantheon.internal.testsupport (rather than being
stored in the same location as their main jar file).