This repository was archived by the owner on Sep 26, 2019. It is now read-only.
[PRIV-41] Refactor PrivacyParameters config to use builder pattern #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antonydenyer
commented
Apr 5, 2019
antonydenyer
commented
- Wire up metrics system to Privacy DBs
- Use PrivacyParametersBuilder to build PrivacyParameters
- Refactor PrivacyParameters to expose default options
- Refactor test builders to use PrivacyParameters.DEFAULT
- Use URI in Enclave
antonydenyer
force-pushed
the
master
branch
4 times, most recently
from
5b3c905 to
9c53623
Compare
- Use PrivacyParametersBuilder to build PrivacyParameters - refactor PrivacyParameters to expose default options - refactor test builders to use PrivacyParameters.DEFAULT - Use URI in Enclave
Contributor
|
I think this PR needs a new title. Metrics is the smallest part of it and refactoring the privacy parameters is the main focus. Metrics isn't used anywhere and is just passed through to the RocksDB config. As far as the metrics goes, we need to update rocksDB's use of metrics to add a label so we know which DB it is getting stats for: the blockchain DB or one of the privacy DBs. But that should ideally be in its own PR. |
shemnon
approved these changes
Apr 9, 2019
Contributor
shemnon
left a comment
shemnon
left a comment
There was a problem hiding this comment.
Approved if the Builder moves to an inner class for consistency. But I'm not locked into that if you want to iterate.
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/core/PrivacyParametersBuilder.java
Outdated
Show resolved
Hide resolved
antonydenyer
changed the title
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
…egaSysEng#1226) * [PRIV-41] Use metrics system for private state db - Use PrivacyParametersBuilder to build PrivacyParameters - refactor PrivacyParameters to expose default options - refactor test builders to use PrivacyParameters.DEFAULT - Use URI in Enclave * Fix: enclave tests from bad merge * Fix privacy acceptance tests after db configuration changes * Switch to use nested class for PrivacyParametersBuilder
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
…egaSysEng#1226) * [PRIV-41] Use metrics system for private state db - Use PrivacyParametersBuilder to build PrivacyParameters - refactor PrivacyParameters to expose default options - refactor test builders to use PrivacyParameters.DEFAULT - Use URI in Enclave * Fix: enclave tests from bad merge * Fix privacy acceptance tests after db configuration changes * Switch to use nested class for PrivacyParametersBuilder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.