Fix csr problem #1104
Merged
Fix csr problem #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…probmel. Warn about a problem of dom.template with a Content-Security-Policy set. If a CSR rule is set then dom.template would break the code unless 'unsafe-eval' is allowed (which you wouldn't normally allow when using a CSR). Therefore it is not recommended to use this template function.
This is a breaking change. Due to a Content-Security-Policy problem with dom.template when unsafe-eval is not set - which you wouldn't set if possible - we had to remove the error-template parameter. Instead the template is now defined in a error_template method on the Patten class and can be customized by subclassing and extending the pat-validation pattern or by patching it via Pattern.prototype.
Do not use dom.template for the wrapper template to not get caught by the browser's Content-Security-Policy. If set, a unsafe-eval error would be thrown and the pattern refuse to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.