Skip to content

Conversation

d-buchmann
Copy link
Contributor

@d-buchmann d-buchmann commented Jun 27, 2025

Link sidebar root nodes to their corresponding "new" route.
Fixes #954

link sidebar root nodes to their corresponding "new" route
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.86%. Comparing base (c445359) to head (a32c875).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Services/Trees/TreeViewGenerator.php 43.75% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #957      +/-   ##
============================================
+ Coverage     59.73%   59.86%   +0.12%     
- Complexity     6036     6038       +2     
============================================
  Files           529      529              
  Lines         20588    20602      +14     
============================================
+ Hits          12298    12333      +35     
+ Misses         8290     8269      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbtronics
Copy link
Member

Thank you.

I changed it so that for now we still have the original behavior, that the root nodes for everything besides projects redirect to "show all parts". I left your code in a way that it should be easily to make the behavior configurable when the new settings system works...

@jbtronics jbtronics merged commit 699a5c9 into Part-DB:master Jul 2, 2025
14 checks passed
@d-buchmann d-buchmann deleted the fix_sidebar_root_node_links branch September 10, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root node of projects menu link to "All parts" instead of "Projects edit"

2 participants