Skip to content

Automatically find "magick" binary #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Automatically find "magick" binary #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class Command
*/
protected $version;

public function __construct(?string $magickBinaryPath = null)
public function __construct(?string $magickBinaryPath = '')
{
$magickBinaryPath = self::findMagickBinaryPath($magickBinaryPath);

Expand Down Expand Up @@ -306,11 +306,11 @@ public function getCommand(): string
/**
* Add a file specification to the command, mostly for source or destination file.
*/
public function file(string $source, bool $checkIfFileExists = true, bool $appendToCommend = false): self
public function file(string $source, bool $checkIfFileExists = true, bool $appendToCommand = false): self
{
$source = $checkIfFileExists ? $this->checkExistingFile($source) : self::cleanPath($source);
$source = \str_replace('\\', '/', $source);
if ($appendToCommend) {
if ($appendToCommand) {
$this->commandToAppend[] = $source;
} else {
$this->command[] = $source;
Expand Down