Fix service datasource returning null due to failing system lookups #617
+62
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The
opslevel_service
data source was completely broken - returningnull
for all fields (name
,description
, etc.) in provider versions > v1.4.0.Impact: 100% failure rate. Every usage of
data "opslevel_service"
would return null for all fields, regardless of whether the service had a parent system or not.Root causes:
service.GetSystem()
which queries a non-existentsystem
field, but the API has aparent
fieldreturn
immediately without saving any statediags
variable was never appended toresp.Diagnostics
, so errors were missingSolution
Changed the
Read()
function inopslevel/datasource_opslevel_service.go
to:service.Parent
directly instead of callingGetSystem()
(avoids the GraphQL error)This approach ensures users get their service data (name, description, etc.) even if optional parent system information isn't available.
Testing
Added integration test
tests/remote/datasource_service.tftest.hcl
that validates all service fields are populated.To manually test:
Expected:
Success! 1 passed, 0 failed.
You can also test with actual Terraform config: