Use constructor args in examples #490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElliotFriend
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar thought to OpenZeppelin/contracs-wizard#723, I noticed a lot of the example contract use hard-codes names, symbols, URIs, etc. This PR aims to abstract those variables into constructor function arguments, and provide some helpful comments to document how to take advantage of these arguments at deploy time with the Stellar CLI
PR Checklist
Not sure if I'm introducing new features here, but all the tests are passing, and I've updated the various README files with args and comments. If that doesn't count, I'm happy to un-check those boxes lol