Increased max buffer size given to solc #17
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12
About the Issue
solc spits out the output to stdout by default.
shell.js uses node's child process that has a limit of 200KB by default on the stdout buffer which is too small.
For example, size of output generated by solc for our contracts with all the flags used here is ~31MB and as a result, doc generation was failing.
Solution
This PR increases max buffer size to 100MB. As this is the max size and it will not be reserved by default, this PR is safe to merge. I have conservatively set it 100MB to detect any future memory leaks. This can be increased in future if need be.