Skip to content

Support private networks and forked networks with Defender #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 8, 2024
Merged

Support private networks and forked networks with Defender #989

merged 14 commits into from
Mar 8, 2024
+383 −34

Conversation

@ericglau
Copy link
Member

@ericglau ericglau commented Mar 7, 2024

Fixes #988

@ericglau ericglau requested a review from MCarlomagno March 7, 2024 01:25
@socket-security
Copy link

socket-security bot commented Mar 7, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@openzeppelin/[email protected] Transitive: environment, filesystem, network +62 9.01 MB collins-oz, dylkil, frangio, ...4 more

View full report↗︎

@ericglau ericglau removed the request for review from MCarlomagno March 7, 2024 15:05
@ericglau ericglau marked this pull request as draft March 7, 2024 15:05
@ericglau ericglau marked this pull request as ready for review March 7, 2024 15:21
@ericglau ericglau requested a review from a team March 7, 2024 16:10
ernestognw
ernestognw reviewed Mar 7, 2024
View reviewed changes
@ericglau ericglau requested a review from ernestognw March 8, 2024 13:42
ernestognw
ernestognw approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ericglau ericglau enabled auto-merge (squash) March 8, 2024 16:15
@ericglau ericglau merged commit 6869419 into OpenZeppelin:master Mar 8, 2024
@ericglau ericglau deleted the privatenetworks branch March 8, 2024 16:17
This was referenced May 7, 2025
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Open
@github-actions github-actions bot mentioned this pull request Jun 26, 2025
Open
This was referenced Jun 28, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestognw ernestognw ernestognw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support private networks for Defender deployments

2 participants

@ericglau @ernestognw