Skip to content

Use upgradeToAndCall depending on upgrade interface version #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 27, 2023
Merged

Use upgradeToAndCall depending on upgrade interface version #883

merged 15 commits into from
Sep 27, 2023

Conversation

@ericglau
Copy link
Member

@ericglau ericglau commented Sep 22, 2023 •
edited
Loading

Fixes #881

This PR enables the use of UUPS implementations and proxy admins from OpenZeppelin Contracts 5.0. Other 5.0 proxy kinds can be imported as well (added test cases).

  • Call upgradeToAndCall depending on UPGRADE_INTERFACE_VERSION
    • when upgrading with a UUPS implementation
    • when upgrading a transparent proxy using a 5.0 proxy admin (which was imported via forceImport)
  • Fixes inferring of UUPS proxies when only upgradeToAndCall is available
  • Add note about changeProxyAdmin not being supported for 5.0 admins or proxies

@ericglau ericglau requested review from Amxx and frangio September 22, 2023 23:01
@ericglau ericglau marked this pull request as draft September 25, 2023 19:53
@ericglau ericglau removed request for Amxx and frangio September 25, 2023 19:53
@socket-security
Copy link

socket-security bot commented Sep 25, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@openzeppelin/contracts 5.0.0-rc.0 None +0 1.69 MB frangio

@ericglau ericglau marked this pull request as ready for review September 25, 2023 21:21
@ericglau ericglau requested a review from frangio September 25, 2023 21:21
@ericglau ericglau mentioned this pull request Sep 25, 2023
Closed
@ericglau ericglau requested a review from a team September 26, 2023 16:10
frangio
frangio reviewed Sep 26, 2023
View reviewed changes
frangio
frangio reviewed Sep 26, 2023
View reviewed changes
frangio
frangio reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments above.

@ericglau ericglau requested a review from frangio September 27, 2023 02:12
Amxx
Amxx reviewed Sep 27, 2023
View reviewed changes
Amxx
Amxx reviewed Sep 27, 2023
View reviewed changes
@ericglau ericglau merged commit 9274324 into OpenZeppelin:master Sep 27, 2023
@ericglau ericglau deleted the upgradeToAndCallHardhat branch September 27, 2023 14:44
This was referenced May 7, 2025
Closed
Merged
Merged
This was referenced May 20, 2025
Merged
Open
This was referenced Jun 26, 2025
Open
Open
Merged
@github-actions github-actions bot mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amxx Amxx Amxx left review comments

@frangio frangio frangio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Call upgradeToAndCall with no data

3 participants

@ericglau @frangio @Amxx