Log solc version in manifest #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericglau
reviewed
Sep 27, 2022
Member
|
Should this include changelog entries (in core, hardhat, and truffle)? |
Co-authored-by: Eric Lau <[email protected]>
ericglau
approved these changes
Sep 27, 2022
This was referenced May 7, 2025
This was referenced May 20, 2025
Merged
This was referenced Jun 26, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #658 (comment).
If we want a chance to support UDVTs in Truffle in the future, we will need the solc version used for a deployed implementation because of #438. This simply adds that information in the StorageLayout objects in the manifest.