-
Notifications
You must be signed in to change notification settings - Fork 286
Add UUPS support #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UUPS support #315
Conversation
7424e41 to
f2a5b12
Compare
f2a5b12 to
8e56c18
Compare
tests updated to use kind: 'transparent' ... need more testing for uups
- use solc 0.6 & 0.7 - add "kind" option for deployProxy and prepareUnpgrade and upgradeProxy - add uups tests
should that be exposed to the user instead/in addition to unsafeAllow ?
97e29bf to
5bdad43
Compare
49e28f7 to
8dfeab8
Compare
frangio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Started reviewing the code. Leaving a couple of initial comments, will continue tomorrow.
packages/plugin-truffle/test/migrations/6_1_deploy_token_transparent.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Francisco Giordano <[email protected]>
Amxx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This used to be the case, but caused issues during manual tests. I'll have to check that again.
Details: cache of old implementation doesn't contain this field, which caused issues.
|
Manual tests look good |
This is solved now because I bumped the validation data version so the cache will be flushed. |
frangio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finished reviewing everything. It looks great.
We need to think about how we want to document this. We can do it in a separate PR.
Changelog
Core - Internal
unsafeAllow: ['no-public-upgrade-fn']which is automatically added by plugins when operating on a transparent proxyPlugin - Public
kindwhich allows users to specify the proxy flavor they want to use. Accepted values areauto(default),uupsandtransparent.autofallback totransparentfor backward compatibilityautowill autodetect the proxy type from the manifest and apply the corresponding checksPlugin - Internal