Defender: Fix proxy deployments when using constructorArgs
#1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
reviewed
May 30, 2024
Co-authored-by: Hadrien Croubois <[email protected]>
Amxx
approved these changes
May 31, 2024
Member
Author
|
Updated to encode constructor data and use |
This was referenced May 7, 2025
This was referenced Jun 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026
Defender deployments are run using the internal
defenderDeployfunction, which takes constructor arguments directly using the...argsargument. This function can deploy proxies or implementations.However, users may provide
constructorArgsto specify constructor args for the implementation contract. These should not apply to the proxy deployment itself.Therefore, the internal
defenderDeployfunction should use itsargsto override the ones inopts.constructorArgs, so that the correct arguments are used for each specific deployment.