Skip to content

Remove outdated comment in ERC-20 #4968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Remove outdated comment in ERC-20 #4968

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be1d266
Remove outdated comment in ERC-20
alexfertel Mar 21, 2024
13db6bf
Rephrase original message
ernestognw Mar 21, 2024
f034421
Adjust comments
ernestognw Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions contracts/token/ERC20/ERC20.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ abstract contract ERC20 is Context, IERC20, IERC20Metadata, IERC20Errors {
/**
* @dev See {IERC20-transferFrom}.
*
* Emits an {Approval} event indicating the updated allowance. This is not
* required by the ERC. See the note at the beginning of {ERC20}.
* Skips emitting an {Approval} event indicating an allowance update. This is not
* required by the ERC. See {xref-ERC20-_approve-address-address-uint256-bool-}[_approve].
*
* NOTE: Does not update the allowance if the current allowance
* is the maximum `uint256`.
Expand Down Expand Up @@ -268,7 +268,8 @@ abstract contract ERC20 is Context, IERC20, IERC20Metadata, IERC20Errors {
*
* Anyone who wishes to continue emitting `Approval` events on the`transferFrom` operation can force the flag to
* true using the following override:
* ```
*
* ```solidity
* function _approve(address owner, address spender, uint256 value, bool) internal virtual override {
* super._approve(owner, spender, value, true);
* }
Expand Down