xenmgr: Push ACPI power button multiple times #200
Conversation
Sometimes the shutdown command does not work. It seems like the longer the VM is up, the more likely it is to not shutdown. This is based on Windows 10 without PV drivers. The button press is seen by the VM to some extent because a DPMS off (black) screen will turn on, but shutdown is not initiated. A second press will trigger it - that was the intent to the xl trigger power line added in commit 1cfb6aa "xenmgr: Add xl trigger power to HVM shutdown". Re-work the code so a background thread is started that will push the power buttons* 3 times each with a 1 second delay. This will hopefully let the VM recognize the button press without going on for too long. *HVMs have two power and two sleep buttons. One is Xen emulating buttons for HVMs, and the second is from QEMU's acpi-pm-features.patch and ACPI changes. xl trigger power is pushing the Xen one and the xenstore hvm-shutdown write is triggering the QEMU one. With forkIO, the `xl shutdown -F -ww` runs before the `xl trigger power` commands. xl shutdown first tries PV shutdown and then (-F) fallback to ACPI. So this would push the Xen ACPI button before the QEMU one in pushPowerButton. Signed-off-by: Jason Andryuk <[email protected]>
|
Still looking at this, but we might be better off just doing a switch and possibly injecting an input event like a mouse move or ctrl key press instead of sending shutdown multiple times. If I can propose an easy way to do this I will. |
|
FYI, redfield would push the button once a second until the vm shutdown.
|
|
The The |
2 participants
Sometimes the shutdown command does not work. It seems like the longer the VM is up, the more likely it is to not shutdown. This is based on Windows 10 without PV drivers.
The button press is seen by the VM to some extent because a DPMS off (black) screen will turn on, but shutdown is not initiated. A second press will trigger it - that was the intent to the xl trigger power line added in commit 1cfb6aa "xenmgr: Add xl trigger power to HVM shutdown".
Re-work the code so a background thread is started that will push the power buttons* 3 times each with a 1 second delay. This will hopefully let the VM recognize the button press without going on for too long.
*HVMs have two power and two sleep buttons. One is Xen emulating buttons for HVMs, and the second is from QEMU's acpi-pm-features.patch and ACPI changes. xl trigger power is pushing the Xen one and the xenstore hvm-shutdown write is triggering the QEMU one.
With forkIO, the
xl shutdown -F -wwruns before thexl trigger powercommands. xl shutdown first tries PV shutdown and then (-F) fallback to ACPI. So this would push the Xen ACPI button before the QEMU one in pushPowerButton.Signed-off-by: Jason Andryuk [email protected]
This was previously included with #193 but can go in independently. I wrote the above a while ago. I think the scenario is Windows without PV drivers. The screen has blanked via DPMS. A single power button press takes it out of DPMS. A second power button press then initiates shutdown. (The VM needs to be configured to shutdown on power button press). So 3 power button presses is more than seems to be strictly necessary, but it's what I wrote and have tested. It doesn't seem to hurt anything to do it more times.