NMS-19032 : Move test utility classes from source to test directory for better code organization. #8050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorantla
requested changes
Oct 22, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Remove original file and remove .circleci triggers, that's only needed for test purposes
Contributor
Remove original EventConfUtil file that you have in src code, ideally it should have reflected as update of the name, not a new file. |
cgorantla
requested changes
Oct 23, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Please remove original file EventConfUtil
# Conflicts: # features/discovery/src/test/java/org/opennms/netmgt/discovery/NewSuspectLocationTest.java # features/vaadin-snmp-events-and-metrics/src/test/java/org/opennms/features/vaadin/events/EventFormTest.java # opennms-config/src/test/java/org/opennms/netmgt/config/EventconfFactoryIT.java # opennms-config/src/test/java/org/opennms/netmgt/config/EventconfFactorySaveTest.java
cgorantla
force-pushed
the
mwa/jira/NMS-19032
branch
from
f3ea3f8 to
94ec331
Compare
cgorantla
approved these changes
Oct 24, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
LGTM! May want to remove ui/yarn.lock changes if not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira : https://opennms.atlassian.net/browse/NMS-19032