NMS-18546: Update SNMP MIB Compiler page to use DB instead of filesystem #8036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahbaz-dataq
changed the title
Shahbaz-dataq
requested review from
aurang-zeb313,
cgorantla,
mwajahatabbasi and
synqotik
synqotik
requested changes
Oct 13, 2025
...ents-and-metrics/src/main/java/org/opennms/features/vaadin/config/EventAdminApplication.java
Outdated
Show resolved
Hide resolved
...ents-and-metrics/src/main/java/org/opennms/features/vaadin/config/EventAdminApplication.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
cgorantla
reviewed
Oct 17, 2025
...din-snmp-events-and-metrics/src/main/java/org/opennms/features/vaadin/events/EventPanel.java
Outdated
Show resolved
Hide resolved
indigo423
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SNMP MIB Compiler page, a Vaadin-based page (features/vaadin-snmp-events-and-metrics, MibCompilerApplication.java) use to compile SNMP MIB files and create event configurations, currently reads from / writes to the filesystem. This needs to be updated to use the database Dao instead.
In MibCompilerPanel, if a user selects and right-clicks on an item in the compiled MIB Tree, and selects Generate Events, then MibCompilerPanel.generateEvents is called, which calls showEventsWindow. which opens an events.EventWindow to display the newly-created events, which haven’t yet been added to the DB.
Save Events File will save to a file. The EventWindow constructor takes both an Events object and a File object. One approach would be to take a DB id or Dao object instead of the File object, or null if this is a newly-generated Event that has not yet been saved, as is the case when coming from the MIB Compiler. Then when user clicks Save Events Filethis can make the DB call. We should avoid creating any temporary .event.xml files; just keep the Events object in memory and eventually write it to the DB using the Dao.
Note that the .mib files themselves will continue to be written to the file system.
External References