NMS-18234: Delete one or more sources by ID (also deletes associated events) #7897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/EventConfPersistenceService.java # opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/EventConfRestService.java # opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/EventConfRestApi.java # opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/EventConfPersistenceServiceIT.java # opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/EventConfRestServiceIT.java
cgorantla
reviewed
Aug 26, 2025
|
|
||
| String hql = "delete from EventConfSource s where s.id in (" + placeholders + ")"; | ||
|
|
||
| int deletedCount = getHibernateTemplate().bulkUpdate(hql, sourceIds.toArray()); |
Contributor
There was a problem hiding this comment.
May be we can improve this:
int deletedCount = getHibernateTemplate().execute(session ->
session.createQuery("delete from EventConfSource s where s.id in (:ids)")
.setParameterList("ids", sourceIds)
.executeUpdate()
);
Contributor
|
Also you need to resolve merge conflicts. |
# Conflicts: # opennms-dao-api/src/main/java/org/opennms/netmgt/dao/api/EventConfSourceDao.java # opennms-dao/src/main/java/org/opennms/netmgt/dao/hibernate/EventConfSourceDaoHibernate.java # opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/EventConfPersistenceService.java # opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/EventConfRestService.java # opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/EventConfRestApi.java # opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/EventConfPersistenceServiceIT.java # opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/EventConfRestServiceIT.java
…events): Implement reviews changes.
cgorantla
approved these changes
Aug 27, 2025
# Conflicts: # opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/EventConfPersistenceServiceIT.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External References