Skip to content

Conversation

@makikorp
Copy link
Contributor

@makikorp makikorp commented Oct 24, 2025

Added service configuration to allow users to configure each service daemon with a boolean to enable and disable them. The default values represent the same configuration as the shipped service-configuration.xml.

Reviewer Hint

  • Normalized the formatting for JSON and YAML files
  • Added the ability to rerun the test manually, in case Kind can't start up correctly

Resolves: #68

Copy link
Member

@indigo423 indigo423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor issues. What do you think?

@indigo423
Copy link
Member

@makikorp, can you clean up the commits by squashing them to just one commit?

@indigo423 indigo423 force-pushed the issue/#68 branch 6 times, most recently from d829792 to 07f02ae Compare October 30, 2025 11:11
@indigo423 indigo423 changed the title Issue/#68 Allow user to control services via environment variables Oct 30, 2025
@indigo423 indigo423 self-requested a review October 30, 2025 11:21
Create configuration parameters for each service and allow enable or
disable service daemons with a boolean true/false.
The default configuration is the same as with a shipped Meridian 2024.x
service-configuration.xml to provide maximum compatibility.

Resolves: #68

Signed-off-by: Ronny Trommer <[email protected]>
Copy link
Member

@indigo423 indigo423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@indigo423 indigo423 merged commit 2786921 into main Oct 30, 2025
1 check passed
@indigo423 indigo423 deleted the issue/#68 branch October 30, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow users to configure OpenNMS service with environment variables

3 participants