Skip to content

NMS-15818: add ability to enable Velocloud #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

NMS-15818: add ability to enable Velocloud #28

wants to merge 5 commits into from
+20 −2

Conversation

@mershad-manesh
Copy link
Contributor

@mershad-manesh mershad-manesh commented Jul 5, 2023 •
edited by mmahacek
Loading

@mershad-manesh mershad-manesh requested a review from deejgregor July 5, 2023 15:33
@mmahacek
Copy link
Contributor

mmahacek commented Jan 18, 2024 •
edited
Loading

I think this just needs a tweak to bump the chart version and then is ready.

mmahacek
mmahacek approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mmahacek mmahacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term, there may need to be a way to enable Velocloud plugin on a Minion, but as there's no init container there, that's a bigger undertaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deejgregor deejgregor Awaiting requested review from deejgregor

1 more reviewer

@mmahacek mmahacek mmahacek approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mershad-manesh @mmahacek