Relax timing on ClientWrapperTest #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternewman
requested changes
Feb 19, 2021
|
Yikes, git-splosion. Let me try that again... |
|
Should be better now... every time I think I know what |
I've always given up and just cherry-picked in the past! |
peternewman
requested changes
Feb 19, 2021
Co-authored-by: Peter Newman <[email protected]>
|
Looks like it's perhaps still not relaxed enough on Arm on a VM (sometimes at least) https://travis-ci.org/github/OpenLightingProject/ola/jobs/759708456 : Traceback (most recent call last): File "../../python/ola/ClientWrapperTest.py", line 201, in testEventLoop AssertionError: datetime.timedelta(0, 0, 5709) != datetime.timedelta(0, 0, 5000) within datetime.timedelta(0, 0, 500) delta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1714.
I allowed up to 500 microseconds of drift in the checks, this way we still catch anything that's wildly off but allow for some minor variance in Python's execution.