Skip to content

Conversation

@josephjclark
Copy link
Collaborator

Description

This PR adds support for gzip-compressed payloads on webhooks.

Closes #3937

Validation steps

See issue

AI Usage

Claude did it all

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

@github-project-automation github-project-automation bot moved this to New Issues in v2 Nov 6, 2025
Copy link
Member

@stuartc stuartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to have some tests to see what happens when the body is malformed for gunzip. We will want a 4xx error and not a 500. But this implementation looks just fine to me.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.74%. Comparing base (fd4d39a) to head (44a618d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/lightning_web/plug_configs.ex 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3938      +/-   ##
==========================================
- Coverage   88.77%   88.74%   -0.04%     
==========================================
  Files         422      422              
  Lines       18625    18629       +4     
==========================================
- Hits        16535    16532       -3     
- Misses       2090     2097       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@josephjclark josephjclark marked this pull request as ready for review November 6, 2025 14:18
@josephjclark
Copy link
Collaborator Author

@stuartc just done a big refactor to make it less shite, and generated some tests. Any thoughts? Can I toss it over the fence from here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Accept gzip encoded content on webhooks

3 participants