-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Fix python example list #8877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python example list #8877
Conversation
|
@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not seeing a sample change?
Could you add a test sample which uses this code path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test sample, and it made me realize it didn't fix it the way I expected it to be fixed. I changed the code, let me know if it makes sense.
4a708a7 to
e97d6fc
Compare
...esources/3_0/python/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml
Outdated
Show resolved
Hide resolved
9178eab to
d40af38
Compare
|
@therve could you rebase on master? |
d40af38 to
b8cee6c
Compare
b8cee6c to
5918fc8
Compare
|
circleci dart issue is a know issue and is not caused by this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR and for adding the tests. This looks good!
CI errors are unrelated to this PR
This fixes python list examples on models by not generating the example when we have model objects, and adding the missing closing character when we don't.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x