Skip to content

Conversation

@therve
Copy link
Contributor

@therve therve commented Mar 3, 2021

This fixes python list examples on models by not generating the example when we have model objects, and adding the missing closing character when we don't.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@therve
Copy link
Contributor Author

therve commented Mar 3, 2021

Copy link
Contributor

@spacether spacether Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not seeing a sample change?
Could you add a test sample which uses this code path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test sample, and it made me realize it didn't fix it the way I expected it to be fixed. I changed the code, let me know if it makes sense.

@therve therve force-pushed the therve/fix-python-list branch 3 times, most recently from 4a708a7 to e97d6fc Compare March 6, 2021 08:03
@therve therve force-pushed the therve/fix-python-list branch from 9178eab to d40af38 Compare March 8, 2021 15:36
@spacether
Copy link
Contributor

@therve could you rebase on master?
Those jaxrs CI errors are odd and should not be happening.

@therve therve force-pushed the therve/fix-python-list branch from d40af38 to b8cee6c Compare March 9, 2021 16:32
@spacether spacether mentioned this pull request Mar 9, 2021
5 tasks
@therve therve force-pushed the therve/fix-python-list branch from b8cee6c to 5918fc8 Compare March 10, 2021 08:23
@spacether
Copy link
Contributor

circleci dart issue is a know issue and is not caused by this pr

@spacether spacether added this to the 5.1.0 milestone Mar 10, 2021
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR and for adding the tests. This looks good!
CI errors are unrelated to this PR

@spacether spacether merged commit 2f047fe into OpenAPITools:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants