Skip to content

[C][Client][Clang Static Analyzer] Fix uninitialized argument value #7305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020
Merged

[C][Client][Clang Static Analyzer] Fix uninitialized argument value #7305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 79 additions & 25 deletions modules/openapi-generator/src/main/resources/C-libcurl/api-body.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ end:
{{#headerParams}}

// header parameters
char *keyHeader_{{{paramName}}};
char *keyHeader_{{{paramName}}} = NULL;
{{#isPrimitiveType}}{{#isNumber}}{{{dataType}}}{{/isNumber}}{{#isLong}}{{{dataType}}}{{/isLong}}{{#isInteger}}{{{dataType}}}{{/isInteger}}{{#isDouble}}{{{dataType}}}{{/isDouble}}{{#isFloat}}{{{dataType}}}{{/isFloat}}{{#isBoolean}}{{dataType}}{{/isBoolean}}{{#isEnum}}{{#isString}}{{projectName}}_{{operationId}}_{{baseName}}_e{{/isString}}{{/isEnum}}{{^isEnum}}{{#isString}}{{{dataType}}} *{{/isString}}{{/isEnum}}{{#isByteArray}}{{{dataType}}}{{/isByteArray}}{{#isDate}}{{{dataType}}}{{/isDate}}{{#isDateTime}}{{{dataType}}}{{/isDateTime}}{{#isFile}}{{{dataType}}}{{/isFile}}{{/isPrimitiveType}}{{^isPrimitiveType}}{{#isModel}}{{#isEnum}}{{datatypeWithEnum}}_e{{/isEnum}}{{^isEnum}}{{{dataType}}}_t *{{/isEnum}}{{/isModel}}{{^isModel}}{{#isEnum}}{{datatypeWithEnum}}_e{{/isEnum}}{{/isModel}}{{#isUuid}}{{dataType}} *{{/isUuid}}{{#isEmail}}{{dataType}}{{/isEmail}}{{/isPrimitiveType}} valueHeader_{{{paramName}}};
keyValuePair_t *keyPairHeader_{{paramName}} = 0;
if ({{paramName}}) {
Expand Down Expand Up @@ -242,12 +242,12 @@ end:

// form parameters
{{#isFile}}
char *keyForm_{{paramName}};
char *keyForm_{{paramName}} = NULL;
{{{dataType}}} valueForm_{{paramName}};
keyValuePair_t *keyPairForm_{{paramName}} = 0;
{{/isFile}}
{{^isFile}}
char *keyForm_{{paramName}};
char *keyForm_{{paramName}} = NULL;
{{#isPrimitiveType}}{{#isNumber}}{{{dataType}}}{{/isNumber}}{{#isLong}}{{{dataType}}}{{/isLong}}{{#isInteger}}{{{dataType}}}{{/isInteger}}{{#isDouble}}{{{dataType}}}{{/isDouble}}{{#isFloat}}{{{dataType}}}{{/isFloat}}{{#isBoolean}}{{dataType}}{{/isBoolean}}{{#isEnum}}{{#isString}}{{projectName}}_{{operationId}}_{{baseName}}_e{{/isString}}{{/isEnum}}{{^isEnum}}{{#isString}}{{{dataType}}} *{{/isString}}{{/isEnum}}{{#isByteArray}}{{{dataType}}}{{/isByteArray}}{{#isDate}}{{{dataType}}}{{/isDate}}{{#isDateTime}}{{{dataType}}}{{/isDateTime}}{{#isFile}}{{{dataType}}}{{/isFile}}{{/isPrimitiveType}}{{^isPrimitiveType}}{{#isModel}}{{#isEnum}}{{datatypeWithEnum}}_e{{/isEnum}}{{^isEnum}}{{{dataType}}}_t *{{/isEnum}}{{/isModel}}{{^isModel}}{{#isEnum}}{{datatypeWithEnum}}_e{{/isEnum}}{{/isModel}}{{#isUuid}}{{dataType}} *{{/isUuid}}{{#isEmail}}{{dataType}}{{/isEmail}}{{/isPrimitiveType}} valueForm_{{paramName}};
keyValuePair_t *keyPairForm_{{paramName}} = 0;
{{/isFile}}
Expand All @@ -272,9 +272,9 @@ end:
// Body Param
{{#isListContainer}}
//notstring
cJSON *localVar_{{paramName}};
cJSON *localVarItemJSON_{{paramName}};
cJSON *localVarSingleItemJSON_{{paramName}};
cJSON *localVar_{{paramName}} = NULL;
cJSON *localVarItemJSON_{{paramName}} = NULL;
cJSON *localVarSingleItemJSON_{{paramName}} = NULL;
if ({{paramName}} != NULL)
{
localVarItemJSON_{{paramName}} = cJSON_CreateObject();
Expand All @@ -300,7 +300,7 @@ end:
}
{{/isListContainer}}
{{^isListContainer}}
cJSON *localVarSingleItemJSON_{{paramName}};
cJSON *localVarSingleItemJSON_{{paramName}} = NULL;
if ({{paramName}} != NULL)
{
//string
Expand Down Expand Up @@ -399,23 +399,41 @@ end:
{{/pathParams}}
{{#headerParams}}
{{#isString}}
free(keyHeader_{{{paramName}}});
if (keyHeader_{{{paramName}}}) {
free(keyHeader_{{{paramName}}});
keyHeader_{{{paramName}}} = NULL;
}
free(valueHeader_{{{paramName}}});
{{/isString}}
{{^isString}}
free(keyHeader_{{{paramName}}});
if (keyHeader_{{{paramName}}}) {
free(keyHeader_{{{paramName}}});
keyHeader_{{{paramName}}} = NULL;
}
{{/isString}}
free(keyPairHeader_{{paramName}});
{{/headerParams}}
{{#bodyParams}}
{{#isListContainer}}
cJSON_Delete(localVarItemJSON_{{paramName}});
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
cJSON_Delete(localVar_{{paramName}});
if (localVarItemJSON_{{paramName}}) {
cJSON_Delete(localVarItemJSON_{{paramName}});
localVarItemJSON_{{paramName}} = NULL;
}
if (localVarSingleItemJSON_{{paramName}}) {
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
localVarSingleItemJSON_{{paramName}} = NULL;
}
if (localVar_{{paramName}}) {
cJSON_Delete(localVar_{{paramName}});
localVar_{{paramName}} = NULL;
}
free(localVarBodyParameters);
{{/isListContainer}}
{{^isListContainer}}
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
if (localVarSingleItemJSON_{{paramName}}) {
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
localVarSingleItemJSON_{{paramName}} = NULL;
}
free(localVarBodyParameters);
{{/isListContainer}}
{{/bodyParams}}
Expand Down Expand Up @@ -451,19 +469,28 @@ end:
{{/queryParams}}
{{#formParams}}
{{#isFile}}
free(keyForm_{{{paramName}}});
if (keyForm_{{{paramName}}}) {
free(keyForm_{{{paramName}}});
keyForm_{{{paramName}}} = NULL;
}
// free(fileVar_{{paramName}}->data);
// free(fileVar_{{paramName}});
free(keyPairForm_{{paramName}});
{{/isFile}}
{{^isFile}}
{{#isString}}
free(keyForm_{{{paramName}}});
if (keyForm_{{{paramName}}}) {
free(keyForm_{{{paramName}}});
keyForm_{{{paramName}}} = NULL;
}
free(valueForm_{{{paramName}}});
free(keyPairForm_{{paramName}});
{{/isString}}
{{^isString}}
free(keyForm_{{{paramName}}});
if (keyForm_{{{paramName}}}) {
free(keyForm_{{{paramName}}});
keyForm_{{{paramName}}} = NULL;
}
free(keyPairForm_{{paramName}});
{{/isString}}
{{/isFile}}
Expand Down Expand Up @@ -492,23 +519,41 @@ end:
{{/pathParams}}
{{#headerParams}}
{{#isString}}
free(keyHeader_{{{paramName}}});
if (keyHeader_{{{paramName}}}) {
free(keyHeader_{{{paramName}}});
keyHeader_{{{paramName}}} = NULL;
}
free(valueHeader_{{{paramName}}});
{{/isString}}
{{^isString}}
free(keyHeader_{{{paramName}}});
if (keyHeader_{{{paramName}}}) {
free(keyHeader_{{{paramName}}});
keyHeader_{{{paramName}}} = NULL;
}
{{/isString}}
free(keyPairHeader_{{paramName}});
{{/headerParams}}
{{#bodyParams}}
{{#isListContainer}}
cJSON_Delete(localVarItemJSON_{{paramName}});
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
cJSON_Delete(localVar_{{paramName}});
if (localVarItemJSON_{{paramName}}) {
cJSON_Delete(localVarItemJSON_{{paramName}});
localVarItemJSON_{{paramName}} = NULL;
}
if (localVarSingleItemJSON_{{paramName}}) {
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
localVarSingleItemJSON_{{paramName}} = NULL;
}
if (localVar_{{paramName}}) {
cJSON_Delete(localVar_{{paramName}});
localVar_{{paramName}} = NULL;
}
free(localVarBodyParameters);
{{/isListContainer}}
{{^isListContainer}}
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
if (localVarSingleItemJSON_{{paramName}}) {
cJSON_Delete(localVarSingleItemJSON_{{paramName}});
localVarSingleItemJSON_{{paramName}} = NULL;
}
free(localVarBodyParameters);
{{/isListContainer}}
{{/bodyParams}}
Expand Down Expand Up @@ -542,18 +587,27 @@ end:
{{/queryParams}}
{{#formParams}}
{{#isFile}}
free(keyForm_{{{paramName}}});
if (keyForm_{{{paramName}}}) {
free(keyForm_{{{paramName}}});
keyForm_{{{paramName}}} = NULL;
}
// free(fileVar_{{paramName}}->data);
// free(fileVar_{{paramName}});
{{/isFile}}
{{^isFile}}
{{#isString}}
free(keyForm_{{{paramName}}});
if (keyForm_{{{paramName}}}) {
free(keyForm_{{{paramName}}});
keyForm_{{{paramName}}} = NULL;
}
free(valueForm_{{{paramName}}});
keyValuePair_free(keyPairForm_{{{paramName}}});
{{/isString}}
{{^isString}}
free(keyForm_{{{paramName}}});
if (keyForm_{{{paramName}}}) {
free(keyForm_{{{paramName}}});
keyForm_{{{paramName}}} = NULL;
}
free(keyPairForm_{{paramName}});
{{/isString}}
{{/isFile}}
Expand Down
49 changes: 35 additions & 14 deletions samples/client/petstore/c/api/PetAPI.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ PetAPI_addPet(apiClient_t *apiClient, pet_t * body )


// Body Param
cJSON *localVarSingleItemJSON_body;
cJSON *localVarSingleItemJSON_body = NULL;
if (body != NULL)
{
//string
Expand Down Expand Up @@ -111,7 +111,10 @@ PetAPI_addPet(apiClient_t *apiClient, pet_t * body )

list_free(localVarContentType);
free(localVarPath);
cJSON_Delete(localVarSingleItemJSON_body);
if (localVarSingleItemJSON_body) {
cJSON_Delete(localVarSingleItemJSON_body);
localVarSingleItemJSON_body = NULL;
}
free(localVarBodyParameters);

}
Expand Down Expand Up @@ -151,7 +154,7 @@ PetAPI_deletePet(apiClient_t *apiClient, long petId , char * api_key )


// header parameters
char *keyHeader_api_key;
char *keyHeader_api_key = NULL;
char * valueHeader_api_key;
keyValuePair_t *keyPairHeader_api_key = 0;
if (api_key) {
Expand Down Expand Up @@ -188,7 +191,10 @@ PetAPI_deletePet(apiClient_t *apiClient, long petId , char * api_key )

free(localVarPath);
free(localVarToReplace_petId);
free(keyHeader_api_key);
if (keyHeader_api_key) {
free(keyHeader_api_key);
keyHeader_api_key = NULL;
}
free(valueHeader_api_key);
free(keyPairHeader_api_key);

Expand Down Expand Up @@ -463,7 +469,7 @@ PetAPI_updatePet(apiClient_t *apiClient, pet_t * body )


// Body Param
cJSON *localVarSingleItemJSON_body;
cJSON *localVarSingleItemJSON_body = NULL;
if (body != NULL)
{
//string
Expand Down Expand Up @@ -504,7 +510,10 @@ PetAPI_updatePet(apiClient_t *apiClient, pet_t * body )

list_free(localVarContentType);
free(localVarPath);
cJSON_Delete(localVarSingleItemJSON_body);
if (localVarSingleItemJSON_body) {
cJSON_Delete(localVarSingleItemJSON_body);
localVarSingleItemJSON_body = NULL;
}
free(localVarBodyParameters);

}
Expand Down Expand Up @@ -544,7 +553,7 @@ PetAPI_updatePetWithForm(apiClient_t *apiClient, long petId , char * name , char


// form parameters
char *keyForm_name;
char *keyForm_name = NULL;
char * valueForm_name;
keyValuePair_t *keyPairForm_name = 0;
if (name != NULL)
Expand All @@ -556,7 +565,7 @@ PetAPI_updatePetWithForm(apiClient_t *apiClient, long petId , char * name , char
}

// form parameters
char *keyForm_status;
char *keyForm_status = NULL;
char * valueForm_status;
keyValuePair_t *keyPairForm_status = 0;
if (status != NULL)
Expand Down Expand Up @@ -594,10 +603,16 @@ PetAPI_updatePetWithForm(apiClient_t *apiClient, long petId , char * name , char
list_free(localVarContentType);
free(localVarPath);
free(localVarToReplace_petId);
free(keyForm_name);
if (keyForm_name) {
free(keyForm_name);
keyForm_name = NULL;
}
free(valueForm_name);
keyValuePair_free(keyPairForm_name);
free(keyForm_status);
if (keyForm_status) {
free(keyForm_status);
keyForm_status = NULL;
}
free(valueForm_status);
keyValuePair_free(keyPairForm_status);

Expand Down Expand Up @@ -638,7 +653,7 @@ PetAPI_uploadFile(apiClient_t *apiClient, long petId , char * additionalMetadata


// form parameters
char *keyForm_additionalMetadata;
char *keyForm_additionalMetadata = NULL;
char * valueForm_additionalMetadata;
keyValuePair_t *keyPairForm_additionalMetadata = 0;
if (additionalMetadata != NULL)
Expand All @@ -650,7 +665,7 @@ PetAPI_uploadFile(apiClient_t *apiClient, long petId , char * additionalMetadata
}

// form parameters
char *keyForm_file;
char *keyForm_file = NULL;
binary_t* valueForm_file;
keyValuePair_t *keyPairForm_file = 0;
if (file != NULL)
Expand Down Expand Up @@ -696,10 +711,16 @@ PetAPI_uploadFile(apiClient_t *apiClient, long petId , char * additionalMetadata
list_free(localVarContentType);
free(localVarPath);
free(localVarToReplace_petId);
free(keyForm_additionalMetadata);
if (keyForm_additionalMetadata) {
free(keyForm_additionalMetadata);
keyForm_additionalMetadata = NULL;
}
free(valueForm_additionalMetadata);
free(keyPairForm_additionalMetadata);
free(keyForm_file);
if (keyForm_file) {
free(keyForm_file);
keyForm_file = NULL;
}
// free(fileVar_file->data);
// free(fileVar_file);
free(keyPairForm_file);
Expand Down
7 changes: 5 additions & 2 deletions samples/client/petstore/c/api/StoreAPI.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ StoreAPI_placeOrder(apiClient_t *apiClient, order_t * body )


// Body Param
cJSON *localVarSingleItemJSON_body;
cJSON *localVarSingleItemJSON_body = NULL;
if (body != NULL)
{
//string
Expand Down Expand Up @@ -289,7 +289,10 @@ StoreAPI_placeOrder(apiClient_t *apiClient, order_t * body )
list_free(localVarHeaderType);

free(localVarPath);
cJSON_Delete(localVarSingleItemJSON_body);
if (localVarSingleItemJSON_body) {
cJSON_Delete(localVarSingleItemJSON_body);
localVarSingleItemJSON_body = NULL;
}
free(localVarBodyParameters);
return elementToReturn;
end:
Expand Down
Loading