Skip to content

[python-exp] Force camelization of imports #7186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2020
Merged

[python-exp] Force camelization of imports #7186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be889f0
[python-exp] Force camelization of imports
timgclark Aug 10, 2020
b5f8f5c
Add unit test
timgclark Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tor/src/main/java/org/openapitools/codegen/languages/PythonClientExperimentalCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public String toDefaultValue(Schema p) {
@Override
public String toModelImport(String name) {
// name looks like Cat
return "from " + modelPackage() + "." + toModelFilename(name) + " import "+ name;
return "from " + modelPackage() + "." + toModelFilename(name) + " import "+ toModelName(name);
}

@Override
Expand Down
8 changes: 8 additions & 0 deletions ...generator/src/test/java/org/openapitools/codegen/python/PythonClientExperimentalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,4 +333,12 @@ public void parseDateAndDateTimeExamplesTest() {
Assert.assertEquals(defaultValue, "dateutil_parser('2010-01-01T10:10:10.000111+01:00')");
}

@Test(description = "format imports of models containing special characters")
public void importSpecialModelNameTest() {
final PythonClientExperimentalCodegen codegen = new PythonClientExperimentalCodegen();

String importValue = codegen.toModelImport("special.ModelName");
Assert.assertEquals(importValue, "from models.special_model_name import SpecialModelName");
}

}