Skip to content

Conversation

@gmtstephane
Copy link
Contributor

With the generated go client, the body response is read and closed inside the function, which is not returned. It is impossible to get the body from the returned value.
I suggest to not close the body and let the user do it with the returned value.

CC @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@gmtstephane gmtstephane mentioned this pull request Jul 24, 2020
5 tasks
@wing328
Copy link
Member

wing328 commented Jul 26, 2020

@gmtstephane thanks for the PR. I think #6948 is related. Can you please review when you've time?

@gmtstephane
Copy link
Contributor Author

Hi,
I confirm #6948 is related.
Both solutions seems good.
My solution more trivial, but clother to the default http package which let you handle the Body closing.

https://golang.org/pkg/net/http/ .

This issue is a bit annoying at the moment since the generated client is not working at all and we have to patch all files each time we generate.

Thanks for your comment

@wing328 wing328 mentioned this pull request Jul 28, 2020
5 tasks
@gmtstephane
Copy link
Contributor Author

  • There is also a problem with CircleCI build, even with the generate samples

@nmische
Copy link
Contributor

nmische commented Jul 29, 2020

@gmtstephane: It is quite possible I am missing something, but how does this allow a user to get the body from the returned http.Response given the body has already been read?

@wing328
Copy link
Member

wing328 commented Aug 4, 2020

Closed via #6948 instead.

@wing328 wing328 closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants