Skip to content

typescript-node: clean up require and import #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 31, 2020
Merged

typescript-node: clean up require and import #6947

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f96c39
Fix for issue 4656 typescript-node generate invalid require statement…
laubfall Jul 15, 2020
0b1d179
Fixed broken link under testing templates
laubfall Jul 15, 2020
dd86be3
Result of run generate-samples.sh / typescript-node*
laubfall Jul 15, 2020
b03d632
import stmt depending on flag supportsES6
laubfall Jul 15, 2020
660e78c
Update petstore sample for typescript-node
laubfall Jul 15, 2020
ad3cde0
import ... from stmt for http/request module
laubfall Jul 27, 2020
547e305
update samples
wing328 Jul 28, 2020
b09227c
update doc
wing328 Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions samples/client/petstore/typescript-node/default/.openapi-generator/FILES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ api/petApi.ts
api/storeApi.ts
api/userApi.ts
git_push.sh
model/apiResponse.ts
model/category.ts
model/order.ts
model/pet.ts
model/tag.ts
model/user.ts
model/./apiResponse.ts
Copy link
Contributor

@DanielRuf DanielRuf Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? ./ makes not much sense in my opinion.

Copy link
Member

@wing328 wing328 Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed ./ is not needed. We'll tackle it separately.

Copy link
Contributor Author

@laubfall laubfall Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so there is nothing left here to todo for the PR?

model/./category.ts
model/./order.ts
model/./pet.ts
model/./tag.ts
model/./user.ts
model/models.ts
12 changes: 6 additions & 6 deletions samples/client/petstore/typescript-node/npm/.openapi-generator/FILES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ api/petApi.ts
api/storeApi.ts
api/userApi.ts
git_push.sh
model/apiResponse.ts
model/category.ts
model/order.ts
model/pet.ts
model/tag.ts
model/user.ts
model/./apiResponse.ts
model/./category.ts
model/./order.ts
model/./pet.ts
model/./tag.ts
model/./user.ts
model/models.ts
package.json
tsconfig.json