Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jul 7, 2020

  • Added isAdditionalPropertiesTrue to indicate whether additionalProperties in the spec is set to true
  • Updated go-experimental template to use isAdditionalPropertiesTrue

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 5.0.0 milestone Jul 8, 2020
@wing328 wing328 merged commit ce177a7 into master Jul 8, 2020
@wing328 wing328 deleted the additional-prop-enhance branch July 8, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants