Skip to content

Conversation

@tgerth
Copy link
Contributor

@tgerth tgerth commented Jul 2, 2020

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/kotlin*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

similar to PR: #6622 which did the same for Java

I'm sorry for this long commit history, that's because of merges, forks and so on.. the important three commits are
"added rx3 support", "generated samples" and "fix rx3 support".

@wing328
Copy link
Member

wing328 commented Jul 5, 2020

"added rx3 support", "generated samples" and "fix rx3 support".

What about creating a new PR by cherry-picking these commits instead? Let me know if you need help.

@tgerth tgerth closed this Jul 20, 2020
@tgerth tgerth deleted the kotlin-rxjava3-support branch July 20, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants