Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jun 26, 2020

  • Run "swiftlint" latest version (0.39.2) on swift petstore samples

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@4brunu
Copy link
Contributor

4brunu commented Jun 26, 2020

Looks good to me 👍

@wing328 wing328 merged commit 720ab3d into master Jun 26, 2020
@wing328 wing328 deleted the swiftlint branch July 15, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants