Skip to content

Conversation

@therve
Copy link
Contributor

@therve therve commented Jun 15, 2020

THis moves the Endpoint class which is in every API modules to the client module where it can be imported.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether

therve added 2 commits June 15, 2020 11:38
The class is copied in every API modules, we can share it alongside the
API client.
@therve therve changed the title Pull request for python-experimental/move-endpoint [Python] Remove duplicate definition of Endpoint class Jun 15, 2020
@spacether
Copy link
Contributor

Thank you for the PR!

@spacether spacether merged commit 380b173 into OpenAPITools:master Jun 16, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants