Skip to content

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jun 12, 2020

For many JVM-based projects, the @javax.annotation.Generated annotation is being used.

Starting with Java 9 and higher, this class is not shipped with the JDK anymore and requires an explicit dependency on javax.annotation:javax.annotation-api which was missing in most of the generators.

This PR adds the dependency in the respective POM, build.gradle, and build.sbt templates and cleans up the usage of the hideGenerationTimestamp property across templates.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.sh to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
    @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

@joschi joschi force-pushed the javax.annotation branch from dd2d4d7 to 2faa9d5 Compare June 13, 2020 07:05
joschi added 2 commits June 13, 2020 09:09
```
bin/generate-samples.sh bin/configs/java-* bin/configs/jaxrs-* bin/configs/spring-* bin/configs/kotlin-* bin/configs/other/java-* bin/configs/other/jaxrs-* bin/configs/other/kotlin-* bin/configs/other/openapi3/jaxrs-cxf-client.yaml bin/configs/other/openapi3/kotlin-*
```
@joschi joschi force-pushed the javax.annotation branch from 2faa9d5 to c473f91 Compare June 13, 2020 07:27
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, which looks good to me 👍

@wing328 wing328 merged commit 32adedd into OpenAPITools:master Jun 14, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jun 14, 2020
@joschi joschi deleted the javax.annotation branch June 14, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants