Skip to content

Conversation

@etherealjoy
Copy link
Contributor

@etherealjoy etherealjoy commented Jun 9, 2020

Fixes the compilation on Windows for Petstore example.
Fixes #6540

@stkrwork @ravinikam @MartinDelille @muttleyxd

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*.
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@etherealjoy etherealjoy added this to the 5.0.0 milestone Jun 10, 2020
@etherealjoy etherealjoy merged commit 31d05f3 into OpenAPITools:master Jun 10, 2020
@etherealjoy etherealjoy deleted the cpprest_fix_petstore_client branch June 17, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][CPPRestSDK] Generated CPPRestSDK client does not compile in Visual Studio 2017

2 participants