[php] Set required PHP version to 7.2 #6603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PHP client package and PHPUnit to meet PHP 7.2 version.
Related issue #6522
Test results from
samples/client/petstore/php/OpenAPIClient-php:With PHPUnit 9:
Tests results from
samples/openapi3/client/petstore/php/OpenAPIClient-php:Fixer detects broken PHP syntax in enum models, but it's obviously not a job for this PR. Should be fixed in future.
With PHPUnit 9:
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*.master,4.3.x,5.0.x. Default:master.cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon