Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jun 8, 2020

For #6178 (comment)

@frol (2017/07) @farcaller (2017/08) @bjgill (2017/12) @richardwhiuk (2019/07) @paladinzh (2020/05)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Jun 8, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.0 milestone Jun 8, 2020
@wing328 wing328 merged commit c176bdc into master Jun 9, 2020
@wing328 wing328 deleted the rust-fix-mod branch June 9, 2020 07:57
jimschubert added a commit that referenced this pull request Jun 9, 2020
* master:
  [ci][cli] Moving ensures script to config-based batch generation of samples (#6509)
  Add Instana to the list of users (#6584)
  [rust][reqwest] fix broken export (#6586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants