Skip to content

Conversation

@richardwhiuk
Copy link
Contributor

When creating a client with middleware, pass the context.

This allows users to pass contextual data about the requests through to the
client middleware.

Note, this is breaking, because:

a) middleware now needs to pass in a DropContextService wrapper when calling Client::try_new_with_client_service() if it's not expecting to use the context.

b) the type of a client has changed (as the Service is now wrapped in a DropContextService).

Rust Server Technical Committee

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

When creating a client with middleware, pass the context.

This allows users to pass contextual data about the requests through to the
client middleware.
@richardwhiuk richardwhiuk added this to the 5.0.0 milestone Jun 6, 2020
@richardwhiuk richardwhiuk merged commit c65363e into OpenAPITools:master Jun 15, 2020
@richardwhiuk richardwhiuk deleted the rust-server-client-middleware branch June 15, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant