[python-client] Enable per-request auth settings #6569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrengray
force-pushed
the
python-access-token
branch
from
ea153f7 to
f0229a6
Compare
warrengray
changed the title
warrengray
changed the title
spacether
reviewed
Jun 10, 2020
modules/openapi-generator/src/main/resources/python/api_client.mustache
Outdated
Show resolved
Hide resolved
spacether
suggested changes
Jun 10, 2020
Contributor
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
Thank you for the PR. Your solution looks good, there is just a small issue where multiple instances of the same auth info can be attached to a request. I noted it in a comment. Can you take a look at it and tweak it so we fix that issue?
warrengray
force-pushed
the
python-access-token
branch
from
a9e5fc2 to
4a4b7dd
Compare
…uth settings when specified.
warrengray
force-pushed
the
python-access-token
branch
from
4a4b7dd to
a8a7672
Compare
spacether
approved these changes
Jun 11, 2020
Contributor
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
Looks great, thank you for the PR!
This was referenced Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6565
The changes are backward compatible with existing wiring since we're only adding optional keyword arguments.
Please forgive me if I've missed something in the contributing guidelines.
@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.