Skip to content

Conversation

@rhuanbarreto
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language. @cliffano @zlx @autopp

This closes #6449

@rhuanbarreto rhuanbarreto changed the title Patch 4 Fix ruby deprecation error May 27, 2020
@wing328 wing328 added this to the 5.0.0 milestone May 28, 2020
@wing328
Copy link
Member

wing328 commented May 28, 2020

The Appveyor failure has been fixed in the master.

@wing328 wing328 merged commit dc48cfd into OpenAPITools:master May 28, 2020
@wing328 wing328 changed the title Fix ruby deprecation error [Ruby] Fix rubocop deprecation error May 28, 2020
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request May 28, 2020
* master:
  Fix ruby deprecation error (OpenAPITools#6450)
  [Java][Feign] decommission 9.x support (OpenAPITools#6445)
  fix struct export in rust reqwest (OpenAPITools#6453)
  [Rust][reqwest] add tests to CI (OpenAPITools#6454)
  set pester version (OpenAPITools#6448)
  update datadog logo
  update groovy petstore samples
  add datadog as sponsor (OpenAPITools#6444)
  Migrate Groovy samples to oas3 (OpenAPITools#6435)
  [samples] Renerate Kotlin coroutines
@rhuanbarreto rhuanbarreto deleted the patch-4 branch September 28, 2020 12:28
@rhuanbarreto
Copy link
Contributor Author

@wing328 this PR was not added in any release. The error persists. Is it in version 5?

@wing328
Copy link
Member

wing328 commented Sep 28, 2020

That will be included in the upcoming v5.0.0 major release.

Please try the 5.0.0-beta2 release with this fix for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Ruby] Rubocop deprecation error

2 participants